Add --exit-on-failure flag to runbms for CI use#169
Conversation
Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
|
@copilot Currently you wait for all invocations within one hfac to finish before checking whether any of them has fail. Check for failure and exit immediately after execution. Pass |
Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
I've implemented immediate exit behavior for the --exit-on-failure flag. The tool now exits with code 1 immediately after any configuration fails, rather than waiting for all invocations within one hfac to complete. The change adds sys.exit(1) calls to all 6 failure scenarios in the run_one_benchmark function. Commit: 5037041 |
|
@copilot Notice that See the GitHub CI configs in the repo for how to run various tests, including running Pass |
Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
You're absolutely right. Since the code now exits immediately on failure when the flag is enabled, the
The logic is now much cleaner - immediate exit on failure when flag is enabled, always exit 0 otherwise. Commit: daf0f96 |
|
@copilot ignore this new flag for dry run. Leave the original code as is. |
Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
I've updated the code to ignore the --exit-on-failure flag for dry run mode. In dry-run mode, the original behavior is preserved - it always exits with code 0 regardless of the flag setting. The change removes the exit logic for SubprocessrExit.Dryrun cases, restoring the original behavior of just printing "." and continuing. Commit: 0d89116 |
|
@copilot Remove |
Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
I've removed the |
|
@copilot Instead of exit 1, change the flag to take an optional argument to allow user to specify the exit code, but default to 1. Update the changelog, and reference documentation as needed. |
…exit code Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
I've updated the
Updated the documentation, changelog, and tests accordingly. Applied black formatting as well. Commit: 7dcb0df |
|
@copilot resolve conflicts |
…figs features Co-authored-by: caizixian <2891235+caizixian@users.noreply.github.com>
Resolved merge conflicts with master branch. The --exit-on-failure and --randomize-configs features now work together seamlessly. Both flags are properly integrated in the command-line parser, documentation, and test suite. All tests pass and code formatting applied. Commit: 6c33f4b |
Implementation Details
Successfully resolved merge conflicts with the master branch that added the
--randomize-configsflag while preserving all functionality of the--exit-on-failureflag. Both features now work together:The merge integrated:
sysandrandommodules)All tests pass and code formatting applied successfully.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.